[js/webgpu] fix buffer size when download #15990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xenova you may want to try if this fixes your error. |
|
Thanks! Is there a place (like https://dev.azure.com/onnxruntime/onnxruntime/_build?definitionId=161&_a=summary&branchFilter=10261%2C10261%2C10261%2C10261%2C10261%2C10261%2C10261&statusFilter=succeeded%2Cwarning) where I can download the build files? Or do I need to build myself? |
|
you need to select the branch filter. the artifacts for this PR is here: https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1010206&view=results |
|
Thanks - got that working. New issue though: |
will do a separated PR for this. |
guschmue
approved these changes
May 19, 2023
fs-eire
added a commit
that referenced
this pull request
May 30, 2023
### Description this is a following up fix for #15990, which should resolve the RangeError issue.
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
### Description fix buffer size when download. buffer size should always be padded to multiple of 4. resolved issue described in microsoft#15796 > 
siweic0
pushed a commit
to siweic0/onnxruntime-web
that referenced
this pull request
May 9, 2024
### Description this is a following up fix for microsoft#15990, which should resolve the RangeError issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix buffer size when download. buffer size should always be padded to multiple of 4.
resolved issue described in #15796